Skip to content

wxwidgets: fix building 3.1 on darwin#163335

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
knl:wxwidgets-3.1-update
Mar 23, 2022
Merged

wxwidgets: fix building 3.1 on darwin#163335
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
knl:wxwidgets-3.1-update

Conversation

@knl
Copy link
Contributor

@knl knl commented Mar 8, 2022 •
edited
Loading

Description of changes

Fix build failures on darwin by passing all the necessary dependencies and removing deprecated command line switches to configure.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@knl knl requested a review from tfmoraes March 8, 2022 14:35
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 8, 2022
@tfmoraes
Copy link
Contributor

tfmoraes commented Mar 8, 2022

@knl there is already a commit in Nixpkg to update wxwidgets #157848

@knl
Copy link
Contributor Author

knl commented Mar 8, 2022

@tfmoraes thanks, haven’t seen it, as I was not looking in staging. Once it reaches master, maybe this PR could be useful, since it fixes building on darwin?

@knl knl force-pushed the wxwidgets-3.1-update branch from 5226418 to 85fda9a Compare March 17, 2022 12:42
@knl knl changed the title wxwidgets: 3.1.4 -> 3.1.5 wxwidgets: fix building 3.1 on darwin Mar 17, 2022
@knl
Copy link
Contributor Author

knl commented Mar 17, 2022

@tfmoraes I updated the PR to make 3.1 build on darwin. Please take a look. I'm wondering should we carve out a dedicated version without gtk, just for mac?

@knl knl force-pushed the wxwidgets-3.1-update branch from 85fda9a to 7d8d130 Compare March 17, 2022 12:45
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 17, 2022
@ofborg ofborg bot requested a review from AndersonTorres March 17, 2022 12:59
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 17, 2022
tfmoraes
tfmoraes reviewed Mar 18, 2022
View reviewed changes
@knl knl force-pushed the wxwidgets-3.1-update branch from 7d8d130 to 73afef8 Compare March 22, 2022 16:19
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Mar 22, 2022
@ofborg ofborg bot requested a review from tfmoraes March 22, 2022 16:39
@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 22, 2022
SuperSandro2000
SuperSandro2000 reviewed Mar 23, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 23, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 23, 2022
View reviewed changes
wxwidgets: fix building on darwin
b22a1d1 
Fix building on darwin by passing in all the dependencies and removing
compilation switches that do not exist anymore.
@knl knl force-pushed the wxwidgets-3.1-update branch from 4610b9c to b22a1d1 Compare March 23, 2022 08:09
@ofborg ofborg bot requested a review from tfmoraes March 23, 2022 09:08
@SuperSandro2000 SuperSandro2000 merged commit 55b85b1 into NixOS:master Mar 23, 2022
@DarkKirb DarkKirb mentioned this pull request Mar 23, 2022
Closed
@willcohen willcohen mentioned this pull request Mar 24, 2022
Merged
13 tasks
DarkKirb added a commit to DarkKirb/nixos-config that referenced this pull request Mar 25, 2022
@DarkKirb
Switch to an older version of nixpkgs
c4ff3bc 
NixOS/nixpkgs#163335 introduced a regression
that we are affected by
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@tfmoraes tfmoraes Awaiting requested review from tfmoraes

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knl @tfmoraes @SuperSandro2000